A task paid by task has a fixed amount, and it is paid as it passes three validations: testing, pull request review and the client's approval. This guide shows how you send a task through them, and how you validate or return one when you are the reviewer.
The three validations
- Testing: someone checks the change works in the testing environment.
- Pull request: someone reviews the code in the pull request.
- Client: the task is delivered to the client, who approves it.
Each request goes to one person, who is told New review requested.:
- Testing goes to the project's QA tester; if the project has none, to its QA lead, and then to its project manager. When the project has none of them, it goes to someone in the company who holds one of those roles.
- Pull request goes to the project's tech lead; if the project has none, to its development lead, and then to its CEO. When the project has none of them, it goes to a development lead or a CEO of the company.
- Client goes to the project's product owner. When the project has none, it goes to a product owner of the company. Only when the company has no product owner does it go to the project manager, projects lead or studio leader, and then to the person who reviews the pull requests.
When the request goes to someone outside the project, that person is picked at random among those who hold the role. Opening the notice takes the reviewer to Task validation, described below. When nobody can be found for a step, the request is still made, but nobody is told.
The testing and pull request share of the payment is scheduled when both of those are approved; the client share, when the client approves. The task finishes on its own once all three are approved. Tasks paid by task have no Finish task button on the board.
Send your task to validation
You do this from the project's task board; see Work on your tasks. On a task whose Type is Task payment, assigned to you or with a payment for you, the buttons at the end of the row are:
- Send to testing: sends it straight away. You see Testing review requested.
- Send PR: opens Send pull request review. Paste the Pull request URL, the full web address of the pull request, and click Send PR. You see Pull request review requested.
- Send to client: opens Send to client validation. Add Optional notes if you want and click Send to client. You see Client validation requested. The window says the request goes to the project's product owner, or to the project manager when there is none, or to the pull request responsible when there is neither; the full order is described above for Client.
Each button shows while its step has not been sent yet, and again when that step was returned or shows Requires re-testing or Requires PR review: click it to send the step once more, and its reviewer is told as the first time. It does not show while the step is waiting for its review, nor once it is approved.
The task's Tags column shows the three steps as QA, PR and Client. Grey means pending, amber in review, green approved and red returned; hover over a step to read its state, such as In QA.
More information on the task shows its Total, Paid, Programmed and Missing amounts, the state of each validation and Open last PR.
When a task is returned
When a reviewer returns your task, you are told Review rejected. Please check the requested changes., and the task shows View comment. Click it to read the Latest rejection comment: who reviewed it, when, the reason and any files attached. When a reviewer approves a step, you are told Review approved. Opening either notification takes you to the project's task board, where you can send the step again.
Returning one step can undo another:
- If testing is returned after the pull request was approved, the pull request shows Requires PR review.
- If the pull request is returned after testing was approved, testing shows Blocked by PR rejection. When the pull request is approved again, testing shows Requires re-testing.
These states show in More information and on the Task validation page; in the Tags column those steps are grey.
Review tasks assigned to you
Choose Task validation in the My panel group of the side menu. The entry is there when you are a project manager, development lead, tech lead, QA tester, QA lead or projects lead. Someone who has been sent a review without one of those roles, such as a product owner, can open the page but does not see the entry in the menu.
The page, Task validation, says Only reviews assigned to you are shown here. Open the task to review its details before validating or returning it. It only lists tasks with a review waiting for you, 15 per page. Narrow the list with:
- Role: the reviewing role you are acting as, among project manager, development lead and QA tester. As QA tester you see testing reviews; as development lead, pull request and client reviews; as project manager, client reviews. The first of your roles is chosen at first, unless your role lets you see every task; with none chosen, the list shows every review waiting for you.
- Project: one of your active projects, or All projects.
- Finished: Not finished at first, Finished or All tasks.
- Review status: In review at first. The other choices are Pending (tasks not finished or not paid yet), All statuses, Approved, waiting for PR, Approved, waiting for testing, Blocked by PR rejection, Requires re-testing, Requires PR review, Approved and Rejected. A task shows when any of its steps is in that state.
When nothing matches, you see No task payments found.
Each task shows its project and sprint, Open PR when it has a pull request, and the steps waiting for you with their state, marked Mine.
- Click View information to read the task before deciding.
- Click Validate on your step to approve it. You see Review approved. and the person who asked for it is told.
- Or click Return to send it back. See below.
Once you validate or return your step, the task leaves your list unless another step is still waiting for you. History shows every request on the task: its step and state, when it was made, Requested by, Reviewer, the link, any reason given and the files attached. Hide history closes it. A task with no requests shows No review history found.
Return a task
- Click Return on your step. Return review opens.
- In Reason, explain what needs to be corrected; it is required. You can use bold, italics, underline, lists and Link, and paste screenshots straight into the text.
- To add files, click Attach images or PDF files. You can attach up to 10 images or PDF files, of up to 10 MB each. While a file uploads you see Uploading file and Return cannot be clicked, so the task never goes back without it. If you see The upload failed. Check your connection and try again., attach the file again.
- Click Return, or Cancel to leave it. You see Review rejected.
The person who asked for the review is told, and sees your reason and files when they open the task.